Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restrictive validity check in caminfo #5553

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

AustinSanders
Copy link
Contributor

@AustinSanders AustinSanders commented Jul 19, 2024

Description

Removes polygon->isValid check. This check is unnecessary, and it does not allow the program to call FixGeometry on the polygon. Multiple validity checks are performed later in Despike, which is part of the control flow of this process.

Related Issue

Closes #5520

How Has This Been Validated?

Program runs to completion on 8.2.0_RC2. PVL was verified against a previous version (8.0.0). All values are the same except emission/incidence angles (which is an expected difference between 8.2.x and 8.0.x, and the footprint values are shifted by 1, i.e. the Polygon values are identical, but the order is slightly different.

Polygons were verified through geos::geom::Polygon::normalize() -- the new values conform to the standard.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@Kelvinrr Kelvinrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests came back fine

@AustinSanders AustinSanders merged commit a59442f into DOI-USGS:dev Jul 22, 2024
1 check passed
@github-actions github-actions bot added the bug Something isn't working label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caminfo - new polygon failures under latest isis on Kaguya TC images
2 participants