Remove restrictive validity check in caminfo #5553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes polygon->isValid check. This check is unnecessary, and it does not allow the program to call FixGeometry on the polygon. Multiple validity checks are performed later in Despike, which is part of the control flow of this process.
Related Issue
Closes #5520
How Has This Been Validated?
Program runs to completion on 8.2.0_RC2. PVL was verified against a previous version (8.0.0). All values are the same except emission/incidence angles (which is an expected difference between 8.2.x and 8.0.x, and the footprint values are shifted by 1, i.e. the Polygon values are identical, but the order is slightly different.
Polygons were verified through geos::geom::Polygon::normalize() -- the new values conform to the standard.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: