[week1] 1차 세미나 과제 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unanchoi
approved these changes
Oct 16, 2023
Comment on lines
+6
to
+30
| @RequiredArgsConstructor(access = AccessLevel.PRIVATE) | ||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| @Getter | ||
| public class BaseResponse<T> { | ||
|
|
||
| private final int code; | ||
|
|
||
| private final String status; | ||
|
|
||
| private final boolean success; | ||
|
|
||
| @JsonInclude(JsonInclude.Include.NON_NULL) | ||
| private T data; | ||
|
|
||
| // 데이터 반환하지 않을 때 | ||
| public static BaseResponse success() { | ||
| return new BaseResponse<>(SuccessCode.OK.getStatusCode(), SuccessCode.OK.getStatus(), true); | ||
| } | ||
|
|
||
| // 데이터 반환할 때 | ||
| public static <T> BaseResponse<T> success(T data) { | ||
| return new BaseResponse<>(SuccessCode.OK.getStatusCode(), SuccessCode.OK.getStatus(), true, data); | ||
| } | ||
|
|
||
| } |
0lynny
reviewed
Oct 20, 2023
There was a problem hiding this comment.
p5;
.gitignore에 .DS_Store 추가해줘도 좋을 것 같아요~!
Comment on lines
+57
to
+61
| @GetMapping("/v8") | ||
| public ResponseEntity<BaseResponse> healthCheckV8() { | ||
| return ResponseEntity.status(SuccessCode.OK.getStatusCode()) | ||
| .body(BaseResponse.success()); | ||
| } |
|
|
||
| @Getter | ||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| public enum SuccessCode { |
There was a problem hiding this comment.
p5;
enum으로 관리하는거 좋은 방법인 것 같아요! 공부해서 제 코드에도 적용해볼게요~!!
Soyewon
approved these changes
Oct 20, 2023
| return ResponseEntity.ok(response); | ||
| } | ||
|
|
||
| @GetMapping("/v5") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
closed #1
✨ 과제 내용
1. 기본 과제
2. 심화 과제
BaseResponse
BaseResponse로 다른 API의 응답 객체로 활용 가능하게 생성함. (데이터 반환하지 않을 때/데이터 반환할 때)@JsonInclude어노테이션을 이용해 data값이 null일 때는 응답에 포함되지 않게 설정함. (데이터 반환하지 않을 때)access = AccessLevel.PRIVATE으로 클래스의 내부에서만 접근 가능하게 함.HealthCheckController
3. 생각 과제
🐥 총 정리
ResponseEntity를 가지고 어떤 형식의 응답을 취해야 할지에 대해 고민해보는 시간이었다.
ResponseEntity를 사용하지 않고 커스텀한 객체만 반환하면, 단순한 형태의 코드가 되지만 헤더의 HTTP Status Code를 설정하지 못한다는 문제점이 있다는 사실을 알게 되었다.