This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Remove pre-converted trit array in test_define.h #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusyong
reviewed
Jan 29, 2019
The pre-converted trit array is generated on little endian machine, tests will not pass on big endian machine, thus trit array need to be generated every time.
jkrvivian
force-pushed
the
remove_trits_81_1_2
branch
from
c345bca
to
39ed03c
Compare
wusyong
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-converted trit array is generated on little endian machine, tests will not pass on big endian machine, thus trit array need to be generated every time.
This bug is fixed:
1/28 meeting, see ajmachine's note