This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Code refactor #60
Merged
Code refactor #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jan 25, 2019
| @@ -4,50 +4,72 @@ | |||
|
|
|||
| int cclient_get_txn_to_approve(const iota_client_service_t* const service, | |||
| ta_get_tips_res_t* res) { | |||
| if (res == NULL) { | |||
There was a problem hiding this comment.
Can you denote the return code listing in core implementation? We shall have conventions in common.
There was a problem hiding this comment.
Two situation here:
- If the function has return value (mostly from entangled), return it directly
- Return
-1for other checks- Check if arguments are valid before execution
- Check if objects are valid after
xxx_new()
There was a problem hiding this comment.
Send another pull request to append return code information for public functions, then can be generated into API Reference Manual later.
There was a problem hiding this comment.
Do you mean descriptions for each function like the link below ?
https://github.com/iotaledger/entangled/blob/eceb7e5604455173e486884cbc79e887e93aa7b3/cclient/iota_client_core_api.h#L38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accelerator/common_core.c: Add ret_code checkingtests/test_serializer.c: Replace constant with macro for consistencytests/test_common.cc: Compare trits withmemcmpto remove redundant tryte_trit conversion