This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Add cache operations to ta_get_transaction_object #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jan 22, 2019
jkrvivian
suggested changes
Jan 22, 2019
added 3 commits
January 23, 2019 12:00
Add cache operations to ta_get_transaction_object and modify how it checks response, because get_trytes always return trytes even if transaction not found.
get_transaction_obj would set value into cache after iota api called. This may cause test case errors since they expect call iota api at least one, but in reality they just find results in cache.
jserv
reviewed
Jan 23, 2019
| @@ -5,6 +5,8 @@ | |||
| #include <stdlib.h> | |||
| #include <string.h> | |||
|
|
|||
| #include "types/types.h" | |||
There was a problem hiding this comment.
For defined macros used in backeend_cache.c
There was a problem hiding this comment.
Affirmative. However, I would like to change the name scheme "types/types.h", which looks lousy. I'll propose changes later.
jserv
reviewed
Jan 23, 2019
| @@ -37,7 +37,7 @@ static int redis_get(redisContext* c, const char* const key, char* res) { | |||
|
|
|||
| redisReply* reply = redisCommand(c, "GET %s", key); | |||
| if (reply->type == REDIS_REPLY_STRING) { | |||
| strcpy(res, reply->str); | |||
| strncpy(res, reply->str, FLEX_TRIT_SIZE_8019); | |||
There was a problem hiding this comment.
FYI. File hooks/scripts/cpplint.py searches for the occurrence of strcpy and warn.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache operations to ta_get_transaction_object and modify how it checks response, because get_trytes always return trytes even if transaction not found.
Part of #55