This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Implement api_get_tips_pair #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jan 13, 2019
| @@ -7,7 +7,7 @@ int cclient_get_txn_to_approve(const iota_client_service_t* const service, | |||
| get_transactions_to_approve_req_new(); | |||
| get_transactions_to_approve_res_t* get_txn_res = | |||
| get_transactions_to_approve_res_new(); | |||
| get_txn_req->depth = 15; | |||
| get_transactions_to_approve_req_set_depth(get_txn_req, 3); | |||
There was a problem hiding this comment.
Max is 15, min is 3. Usually it's fine to set depth to minimum, but default docs would show 15 intentionally.
There was a problem hiding this comment.
Insert the relevant code comment(s) about depth.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.