This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Refactor server handler #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrvivian
suggested changes
Jan 8, 2019
jserv
reviewed
Jan 8, 2019
jkrvivian
suggested changes
Jan 8, 2019
added 3 commits
January 9, 2019 11:18
Refine boost library with served as http server handler. Following API requests with GET are also implemented: * GET /tag * GET /tips (fetch all tips) * GET /address
jserv
reviewed
Jan 9, 2019
| return EXIT_SUCCESS; | ||
| #include <served/plugins.hpp> | ||
| #include <served/served.hpp> | ||
| #include "./apis.h" |
There was a problem hiding this comment.
The prefix ./ looks redundant. Can you eliminate it?
There was a problem hiding this comment.
This is required for cpplint:
Include the directory when naming .h files [build/include] [4]
jserv
reviewed
Jan 9, 2019
config.h
Outdated
| // Address binding and port for tangle-accelerator | ||
| #define TA_HOST "localhost" | ||
| #define TA_PORT "8000" | ||
| #define TA_THREAD 10 |
There was a problem hiding this comment.
It can be explicit if changed to TA_THREAD_COUNT.
jserv
reviewed
Jan 9, 2019
server.cc
Outdated
| cJSON_AddStringToObject(json_obj, "message", "Invalid path"); | ||
| const char* json = cJSON_PrintUnformatted(json_obj); | ||
|
|
||
| res.set_status(400); |
There was a problem hiding this comment.
Can you enumerate the possible error codes?
There was a problem hiding this comment.
According to Tangle-Accelerator Core API. We have 400 for client bad request and 404 for request not found.
There was a problem hiding this comment.
Let's introduce macro(s) to map these error codes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine boost library with served as http server handler. Following API requests with GET are also implemented: