This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Implement api_generate_address #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use |
jserv
reviewed
Dec 21, 2018
tangle_accelerator_core_api.c
Outdated
| } | ||
|
|
||
| ta_generate_address_res_serialize(&json_result, res); | ||
| if (ret) { |
There was a problem hiding this comment.
Will ret be changed in previous line?
There was a problem hiding this comment.
If goto is used right after if (ret), this function would look lighter.
There was a problem hiding this comment.
Also the last check is not needed I think
jkrvivian
force-pushed
the
api_generate_address
branch
from
1951a67
to
f9a0c15
Compare
wusyong
previously approved these changes
Dec 21, 2018
jserv
reviewed
Dec 21, 2018
tangle_accelerator_core_api.c
Outdated
|
|
||
| ret = ta_generate_address_res_serialize(&json_result, res); | ||
| if (ret) { | ||
| goto done; |
|
Rebasing is required. |
jkrvivian
force-pushed
the
api_generate_address
branch
from
69e62f7
to
a6c42e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6