Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

Fix conflicting CLI options iri_host, iri_port and iri_address #584

Closed
YingHan-Chen opened this issue Apr 23, 2020 · 1 comment
Closed

Fix conflicting CLI options iri_host, iri_port and iri_address #584

YingHan-Chen opened this issue Apr 23, 2020 · 1 comment
Assignees
@YingHan-Chen
Labels
A-config Area - Config or CLI C-bug Category - Something isn't working

Comments

@YingHan-Chen
Copy link
Contributor

No description provided.

@YingHan-Chen YingHan-Chen self-assigned this Apr 23, 2020
@YingHan-Chen YingHan-Chen changed the title Fix conflict CLI option iri_host, iri_port and iri_address Fix conflicting CLI options iri_host, iri_port and iri_address Apr 23, 2020
YingHan-Chen added a commit to YingHan-Chen/tangle-accelerator that referenced this issue Apr 23, 2020
@YingHan-Chen
fix(core): integrate conflicting IOTA conf and correct CLI conf
c285351 
Remove CLI option `iri_address` that will overwrite options `iri_host` and `iri_port`.

Make options  `iri_host` and  `iri_port` support multiple addresses separated by comma.
For example `./accelerator --iri_host  host1,host2, ...`

Correct the misused TA binding port and address.
Correct error casting and range checking of CLI options.
Close DLTcollab#583 DLTcollab#584
YingHan-Chen added a commit to YingHan-Chen/tangle-accelerator that referenced this issue Apr 23, 2020
@YingHan-Chen
fix(core): integrate conflicting IOTA conf and fix incorrect TA conf
181d1e2 
Remove CLI option `iri_address` that will overwrite options `iri_host` and `iri_port`.

Make options  `iri_host` and  `iri_port` support multiple addresses separated by comma.
For example `./accelerator --iri_host  host1,host2, ...`

Correct the misused TA binding port and address.
Correct error casting and range checking of CLI options.
Close DLTcollab#583 DLTcollab#584
YingHan-Chen added a commit to YingHan-Chen/tangle-accelerator that referenced this issue Apr 23, 2020
@YingHan-Chen
fix(core): integrate conflicting IOTA conf and fix incorrect TA conf
616856a 
Remove CLI option `iri_address` that will overwrite options `iri_host` and `iri_port`.

Make options  `iri_host` and  `iri_port` support multiple addresses separated by comma.
For example `./accelerator --iri_host  host1,host2, ...`

Correct the misused TA binding port and address.
Correct error casting and range checking of CLI options.

Close DLTcollab#583 DLTcollab#584
@YingHan-Chen YingHan-Chen mentioned this issue Apr 23, 2020
Merged
howjmay pushed a commit to howjmay/tangle-accelerator that referenced this issue Apr 28, 2020
@YingHan-Chen @howjmay
fix(core): integrate conflicting IOTA conf and fix incorrect TA conf
0ae02c2 
Remove CLI option `iri_address` that will overwrite options `iri_host` and `iri_port`.

Make options  `iri_host` and  `iri_port` support multiple addresses separated by comma.
For example `./accelerator --iri_host  host1,host2, ...`

Correct the misused TA binding port and address.
Correct error casting and range checking of CLI options.

Close DLTcollab#583 DLTcollab#584
@howjmay
Copy link
Contributor

howjmay commented Apr 28, 2020

Fixes in #585

@howjmay howjmay closed this as completed Apr 28, 2020
@howjmay howjmay added A-config Area - Config or CLI C-bug Category - Something isn't working labels Apr 28, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YingHan-Chen YingHan-Chen

Labels
A-config Area - Config or CLI C-bug Category - Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YingHan-Chen @howjmay