Integrate duplicated PoW testing code into a file #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furuame
requested changes
Sep 11, 2018
|
Could you attach the output message (after running |
jserv
reviewed
Sep 11, 2018
| for (int i = 243 - 1; i >= 243 - mwm; i--) { | ||
| assert(ret_trits->data[i] == 0); | ||
| } | ||
| ImplContext ImplContextArr[ ] = { |
There was a problem hiding this comment.
In this way, you have to enumerate two sets of implementations. Can you reduce the amount of #if and #endif statements by some C99 tricks?
|
This pull request was meant to resolve issue #60. You shall append |
The selected hardware acceleration are added by user-defined macro.
$ make check output message:
*** Validating build/test-trinary ***
[ Verified ]
*** Validating build/test-curl ***
[ Verified ]
*** Validating build/test-dcurl ***
[ Verified ]
*** Validating build/test-multi-pow ***
[ Verified ]
*** Validating build/test-pow ***
CPU - SSE
Success.
[ Verified ]
Close DLTcollab#60.
marktwtn
force-pushed
the
unify-pow-test
branch
from
aac53bb
to
0bea478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selected hardware acceleration are added by user-defined macro.
Output message: