Sanity check for OpenCL Library #65
Conversation
mk/opencl.mk
Outdated
| OPENCL_LIB ?= /usr/local/cuda-9.1/lib64 | ||
| OPENCL_LIB_PATH ?= /usr/local/cuda/lib64 | ||
|
|
||
| OPENCL_LIB := $(shell test -d $(OPENCL_LIB_PATH); echo $$?) |
There was a problem hiding this comment.
Can you validate some critical headers as well?
There was a problem hiding this comment.
Which headers do you refer? Something like CL/cl.h in this case?
There was a problem hiding this comment.
Users might specify other OpenCL implementation rather than the one shipped by NVIDIA SDK. Take Beignet for example, it is an implementation dedicated to Intel Graphics and suitable for CI purpose. However, it is hard for current scripts to detect its availability.
There was a problem hiding this comment.
The availability of Beignet should be included in another issue #69.
mk/opencl.mk
Outdated
| LDFLAGS += -L$(OPENCL_LIB) -lOpenCL | ||
| -I$(OPENCL_LIB_PATH)/../include | ||
|
|
||
| LDFLAGS += -L$(OPENCL_LIB_PATH) -lOpenCL |
There was a problem hiding this comment.
Before assigning $(LDFLAGS), we shall ensure the presence of OpenCL runtime library in advance.
There was a problem hiding this comment.
Do you mean check the presence of libOpenCL.so ?
|
@marktwtn, Be aware of the availbility of Intel OpenCL driver which might be required by Travis-CI. |
|
Related: #69 |
furuame
force-pushed
the
opencl-sanity-check
branch
from
1423ddf
to
145ac16
Compare
furuame
force-pushed
the
opencl-sanity-check
branch
from
145ac16
to
94ec2c9
Compare
|
@jserv Should the OpenCL sanity check include the Travis-CI coverage? |
CI changes could be addressed in another pull request. Let's concentrate on OpenCL validation here. |
No description provided.