Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Increase the default thread pool size of libtuv #142

Closed

Conversation

marktwtn
Copy link
Collaborator

The dcurl can not affect the thread pool size of libtuv.
For allowing more threads to calculate the PoW,
the size must be increased.
The default pool size is changed from 4 to 26.

The dcurl can not affect the thread pool size of libtuv.
For allowing more threads to calculate the PoW,
the size must be increased.
The default pool size is changed from 4 to 26.
@marktwtn marktwtn requested review from jserv and wusyong April 25, 2019 06:21
@jserv
Copy link
Member

jserv commented Apr 25, 2019

I dislike such modifications. The default value is valid for libtuv's motivation and purpose on IoT devices. We can refer to runtime configurations in order to calibrate CPU resources. Also, consider the case when HyperThreading is enabled.

@marktwtn
Copy link
Collaborator Author

marktwtn commented May 5, 2019

I'll figure out another method for changing the thread pool size.
The pull request is not going to be merged.

@marktwtn marktwtn closed this May 5, 2019
@marktwtn marktwtn deleted the increase-thread-pool-size branch May 5, 2019 08:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants