-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the hash rate of each implementation #47
Comments
@marktwtn Please reference the implementation in iotaledger/giota |
The current implementation of getting the hash times would be calling an API It would call the corresponding hardware-related function.
The GPU implementation is still under investigation. |
@marktwtn About hash times of the OpenCL, you can take a look from giota. It seems trivial. https://github.com/iotaledger/giota/blob/e34a409290248e6ff2205b06062d702690910f04/pow_cl.go#L94 |
Obtain the hash times mentioned in DLTcollab#47 with API.
Obtain the hash times mentioned in DLTcollab#47 in `doThePoW` function
Calculate the hash count mentioned in DLTcollab#47 in `doThePoW` function and get it with `getHashCount` API.
There are two ways to get the
However, if the time unit is second, I think the I prefer the method 2. And I am thinking that the |
Method 2 might be better to get the time. But I'm not sure do we really need "three" APIs to achieve the goal of this enhancement? |
How about
or
|
Let's do this! Create an API |
Here are the modifications I am going to do: The return pointer of I assume the |
It's no need to return a pointer to a struct. Just return the value of the struct.
Good idea. After merging this PR, I will refactor the code to follow the OOP style. |
This is what I am going to do.
@jserv is this what you expect to see? |
The original goal of this issue is achieved. Let's create another issue for these features. |
Show the hash rate of each implementation by using
BUILD_BENCH
optionThe text was updated successfully, but these errors were encountered: