Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure of using BUILD_REMOTE=1 and BUILD_JNI=1 options #166

Closed
marktwtn opened this issue Jun 26, 2019 · 0 comments · Fixed by #167
Closed

Build failure of using BUILD_REMOTE=1 and BUILD_JNI=1 options #166

marktwtn opened this issue Jun 26, 2019 · 0 comments · Fixed by #167
Assignees
@marktwtn
Labels
bug Something isn't working
Milestone
Watercress

Comments

@marktwtn
Copy link
Collaborator

Error message:

make[1]: *** No rule to make target 'build/worker-jni/iri-pearldiver-exlib.o',
needed by 'build/remote-worker'.  Stop.

The Makefile does not take care of the situation of enabling the build options BUILD_REMOTE and BUILD_JNI=1 at the same time.
Besides fixing it, the CI should add the corresponding building test.
@marktwtn marktwtn added the bug Something isn't working label Jun 26, 2019
@marktwtn marktwtn added this to the Watercress milestone Jun 26, 2019
@marktwtn marktwtn self-assigned this Jun 26, 2019
marktwtn added a commit to marktwtn/dcurl that referenced this issue Jun 28, 2019
@marktwtn
fix: fix build error with BUILD_REMOTE and BUILD_JNI enabled
d99addb 
The JNI related object file is included in the remote worker related object files
if the build options BUILD_REMOTE and BUILD_JNI are enabled.
This should not happen and it causes the building error.
The commit make sure the un-related object files would not be included.

Close DLTcollab#166.
@marktwtn marktwtn mentioned this issue Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marktwtn marktwtn

Labels
bug Something isn't working
Projects
None yet
Milestone
Watercress
Development

Successfully merging a pull request may close this issue.

fix: fix build error with BUILD_REMOTE and BUILD_JNI enabled marktwtn/dcurl
1 participant
@marktwtn