Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote interface: Integrate IRI #152

Closed
ajblane opened this issue May 9, 2019 · 2 comments · Fixed by #168
Closed

Remote interface: Integrate IRI #152

ajblane opened this issue May 9, 2019 · 2 comments · Fixed by #168
Assignees
@ajblane @marktwtn
Labels
feature Outstanding features we should implement
Milestone
Watercress

Comments

@ajblane
Copy link
Collaborator

ajblane commented May 9, 2019 •
edited
Loading

Related to #133
Related to https://github.com/DLTcollab/general/issues/149
Related to https://github.com/DLTcollab/general/issues/147
@ajblane ajblane self-assigned this May 9, 2019
@ajblane ajblane mentioned this issue May 9, 2019
Closed
@ajblane ajblane changed the title Integrate IRI with remote interface Remote interface: Integrate IRI May 9, 2019
@jserv jserv added the feature Outstanding features we should implement label Jun 16, 2019
@marktwtn marktwtn self-assigned this Jun 28, 2019
@marktwtn marktwtn added this to the Watercress milestone Jun 28, 2019
@marktwtn
Copy link
Collaborator

The way we use remote interface is to dynamically link the rabbitMQ shared library.

In the dcurl executable files, it works well.
However, it has some problem with the IRI integration.
IRI uses dcurl with its shared library libdcurl.so, and it can not load the librabbitmq.so correctly.

I'll try to figure out another way to use remote interface without any problem.

@marktwtn
Copy link
Collaborator

marktwtn commented Jul 2, 2019

I decide to use rabbitMQ position-independent object files instead of its shared library.
The dcurl executable files and shared library would be compiled with the extra rabbitMQ objects files, which increases the size.
However, it is much straightforward.

marktwtn added a commit to marktwtn/dcurl that referenced this issue Jul 3, 2019
@marktwtn
fix(build): Use rabbitMQ object files instead of shared library
d88c01a 
The final generated libdcurl.so should be able
to use the submodule projects directly without any dynamic linking.
Otherwise, the integration with IRI would have problem.

Since dcurl builds with the object files of the submodule projects,
the variable naming is changed from LIBRARY to OBJS.

Close DLTcollab#152.
marktwtn added a commit to marktwtn/dcurl that referenced this issue Jul 3, 2019
@marktwtn
fix(build): Use rabbitMQ object files instead of shared library
11e1f7a 
The final generated libdcurl.so should be able
to use the submodule projects directly without any dynamic linking.
Otherwise, the integration with IRI would fail.

Since dcurl builds with the object files of the submodule projects,
the variable naming is changed from _LIBRARY to _OBJS.

Close DLTcollab#152.
@marktwtn marktwtn mentioned this issue Jul 3, 2019
Merged
marktwtn added a commit to marktwtn/dcurl that referenced this issue Jul 5, 2019
@marktwtn
fix(build): Use RabbitMQ object files instead of shared library
5f881fa 
The final generated libdcurl.so should be able
to use the submodule projects directly without any dynamic linking.
Otherwise, the integration with IRI would fail.

Since dcurl builds with the object files of the submodule projects,
the variable naming is changed from _LIBRARY to _OBJS.

Close DLTcollab#152.
@jserv jserv closed this as completed in #168 Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajblane ajblane

@marktwtn marktwtn

Labels
feature Outstanding features we should implement
Projects
None yet
Milestone
Watercress
Development

Successfully merging a pull request may close this issue.

fix(build): Use RabbitMQ object files instead of shared library marktwtn/dcurl
3 participants
@jserv @ajblane @marktwtn