Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated indices table #109

Closed
jserv opened this issue Feb 16, 2019 · 0 comments
Closed

Duplicated indices table #109

jserv opened this issue Feb 16, 2019 · 0 comments
Assignees
@marktwtn
Labels
bug Something isn't working
Milestone
sprint-201902

Comments

@jserv
Copy link
Member

jserv commented Feb 16, 2019

There are two indices tables existing in file src/constants.c and src/curl.c. They are identical, and we can remove the one in file src/curl.c and defer to src/constants.[ch].

[before cleanup]

$ size build/libdcurl.so 
   text	   data	    bss	    dec	    hex	filename
  80244	   1632	   1248	  83124	  144b4	build/libdcurl.so

[after cleanup]

$ size build/libdcurl.so 
   text	   data	    bss	    dec	    hex	filename
  77308	   1632	   1248	  80188	  1393c	build/libdcurl.so
@jserv jserv added the bug Something isn't working label Feb 16, 2019
@jserv jserv added this to the sprint-201902 milestone Feb 16, 2019
marktwtn added a commit to marktwtn/dcurl that referenced this issue Feb 16, 2019
@marktwtn
Remove duplicated array
57c3276 
Close DLTcollab#109.
@marktwtn marktwtn mentioned this issue Feb 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marktwtn marktwtn

Labels
bug Something isn't working
Projects
None yet
Milestone
sprint-201902
Development

No branches or pull requests
2 participants
@jserv @marktwtn