Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify thread synchronization APIs with libtuv #107

Closed
jserv opened this issue Feb 16, 2019 · 2 comments
Closed

Unify thread synchronization APIs with libtuv #107

jserv opened this issue Feb 16, 2019 · 2 comments
Assignees
@marktwtn
Labels
feature Outstanding features we should implement
Milestone
Fumitory

Comments

@jserv
Copy link
Member

jserv commented Feb 16, 2019

Since libtuv is integrated into dcurl, we can unify the use of thread synchronization with libtuv APIs. Specifically, all occurrence of mutex and semaphore can be replaced with the corresponding libtuv equivalents, which are implemented with cross-platform support in mind. It implies that we can concentrate on abstract computing and resource management without enumerating GNU/Linux, macOS, and even MS-Windows ports.
@jserv
Copy link
Member Author

jserv commented Feb 16, 2019

Related: #102

@jserv jserv added the feature Outstanding features we should implement label Feb 16, 2019
@marktwtn marktwtn added this to the Burdock milestone Mar 4, 2019
@marktwtn
Copy link
Collaborator

Although replacing thread synchronization APIs with libtuv is trivial, it would have issue when compiling dcurl on other platform.
For example, the de10 nano hardware platform.
Check #105 for reference.

The libtuv needs to specify the supported hardware and OS, but the current detection method in mk/submodule.mk is quite simple.

@wusyong wusyong modified the milestones: Hemlock, Fumitory Mar 18, 2019
This was referenced Mar 20, 2019
Closed
Merged
marktwtn added a commit to marktwtn/dcurl that referenced this issue Mar 26, 2019
@marktwtn
feat: Make thread synchronization portable
9204c54 
Replace the thread synchronization functions with the portable
libtuv APIs and remove the unused code.

TODO:
Make mutex of src/compat-ccurl.c portable.

Close DLTcollab#107.
@marktwtn marktwtn mentioned this issue Mar 26, 2019
Merged
marktwtn added a commit to marktwtn/dcurl that referenced this issue Mar 28, 2019
@marktwtn
feat: Make thread synchronization portable
db6b6f9 
Replace the thread synchronization functions with the portable
libtuv APIs and remove the unused code.

TODO:
Make mutex of src/compat-ccurl.c portable.

Close DLTcollab#107.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marktwtn marktwtn

Labels
feature Outstanding features we should implement
Projects
None yet
Milestone
Fumitory
Development

No branches or pull requests
3 participants
@jserv @marktwtn @wusyong