Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored ContinuousCritic for SAC/TD3 #78

Merged
merged 6 commits into from
Jul 6, 2020

Conversation

araffin
Copy link
Member

@araffin araffin commented Jun 30, 2020

Description

Preparing #3, it merges SAC and TD3 critics and it will be used by DDPG soon.
I added a parameter n_critics, even though SAC/TD3 only support n_critics=2 for now. (It will be mainly useful for DDPG)

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have checked the codestyle using make lint
  • I have ensured make pytest and make type both pass.

@araffin araffin mentioned this pull request Jun 30, 2020
42 tasks
docs/misc/changelog.rst Outdated Show resolved Hide resolved
@Miffyli
Copy link
Collaborator

Miffyli commented Jun 30, 2020

Left couple of comments, just doc stuff. Other than that it looks good to me 👍

@araffin araffin requested a review from Miffyli July 6, 2020 09:23
@araffin
Copy link
Member Author

araffin commented Jul 6, 2020

@Miffyli sorry, I did my edits last week but did not pushed them...

@Miffyli
Copy link
Collaborator

Miffyli commented Jul 6, 2020

Looks good to me :)

sorry, I did my edits last week but did not pushed them...

No biggie, happens to all of us :D

@Miffyli Miffyli merged commit 3756d05 into master Jul 6, 2020
@araffin araffin deleted the refactor/off-policy-critic branch July 7, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants