Fix gSDE loading issue in test mode #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGleave
reviewed
Jun 5, 2020
stable_baselines3/sac/policies.py
Outdated
| :param batch_size: (int) | ||
| """ | ||
| assert isinstance(self.actor.action_dist, StateDependentNoiseDistribution), \ | ||
| 'reset_noise() is only available when using gSDE' |
There was a problem hiding this comment.
I try and avoid \ in Python; maybe msg = ... and then assert cond, msg?
Shunian-Chen
pushed a commit
to Shunian-Chen/AIPI530
that referenced
this pull request
Nov 14, 2021
* removed policy from save, changed th.loads to map to device * found hack: catch pickle exception and trying th.load with mapping instead, otherwise raise exception with more information -> loading cuda on cpu raises exception -> leads to th.load with map being called * deleted todo * updated changelog * start of saving refactor * first working c * all tests pass, save refactored * - backwards compatibilty not always - make pytest all passing - make typing all passing * Fixes and simplify the save method * Remove unused param * Fix backward compat * Fix docstring
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #44
related to DLR-RM/rl-baselines3-zoo#18
unfortunately, we cannot test that :/ (maybe we should add some loading/saving tests on cpu/gpu at some point, when available)
Motivation and Context
Types of changes
Checklist:
make lintmake pytestandmake typeboth pass.