test_buffers.py::test_device
was not actually checking the device of tensors
#1685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a failure in case of unknown type to
test_buffers.py::test_device
, and made it iterate correctly through Tensors and dicts.Motivation and Context
In
test_buffers.py::test_device
, the assertions that the device be the correct one would not be executed forRolloutBuffer
andDictRolloutBuffer
: the type ofvalue
isRolloutBufferSamples
andDictRolloutBufferSamples
respectively and so falls to theelse
case.I have not raised an issue on purpose, why bother for a tiny bugfix.
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line