Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed fix for RunningMeanStd overflow #1954

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

spiglerg
Copy link

@spiglerg spiglerg commented Jun 29, 2024

Connected to Issue #1953

Description

RunningMeanStd is made robust to overflows with two modifications:

  • the product that can produce overflows when `count' becomes too large is split into a product of smaller quantities;
  • overflow exceptions are detected, and in that case normalization counts are rescaled, and the function is called again.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RunningMeanStd overflowing
1 participant