Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: RunningMeanStd overflowing #1953

Open
4 of 5 tasks
spiglerg opened this issue Jun 29, 2024 · 1 comment · May be fixed by #1954
Open
4 of 5 tasks

[Bug]: RunningMeanStd overflowing #1953

spiglerg opened this issue Jun 29, 2024 · 1 comment · May be fixed by #1954
Labels
bug Something isn't working check the checklist You have checked the required items in the checklist but you didn't do what is written...

Comments

@spiglerg
Copy link

spiglerg commented Jun 29, 2024 •
edited
Loading

🐛 Bug

RunningMeanStd is not overflow safe, and overflows when running large-scale training (e.g., on a cluster).

To Reproduce

I'm submitting a pull request with a proposal to address the problem.

Relevant log output / Error message

No response

System Info

No response

Checklist

  • My issue does not relate to a custom gym environment. (Use the custom gym env template instead)
  • I have checked that there is no similar issue in the repo
  • I have read the documentation
  • I have provided a minimal and working example to reproduce the bug
  • I've used the markdown code blocks for both code and stack traces.
@spiglerg spiglerg added the bug Something isn't working label Jun 29, 2024
@spiglerg spiglerg linked a pull request Jun 29, 2024 that will close this issue
Open
8 tasks
@araffin araffin added the check the checklist You have checked the required items in the checklist but you didn't do what is written... label Jun 29, 2024
@araffin
Copy link
Member

araffin commented Jul 5, 2024

I have provided a minimal and working example to reproduce the bug

hello please do not forget this step, that would allow us better to understand the problem and when it occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working check the checklist You have checked the required items in the checklist but you didn't do what is written...
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proposed fix for RunningMeanStd overflow spiglerg/sb3-fix-runningmeanstd
2 participants
@araffin @spiglerg