Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease gamma for SAC/TQC on Swimmer-v4 #447

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

JacobHA
Copy link
Contributor

@JacobHA JacobHA commented Apr 29, 2024

some experiments indicate that gamma=0.999 is better for swimmer, in agreement with https://arxiv.org/pdf/2208.07587 Fig. 4

Description

I've simply decreased gamma for SAC on Swimmer, motivated by experiments.

Motivation and Context

The current value of gamma fails for Swimmer-v4 on SAC.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

image

Note: we are using a maximum length of 127 characters per line

some experiments indicate that gamma=0.999 is better for swimmer, in agreement with https://arxiv.org/pdf/2208.07587 Fig. 4
@araffin
Copy link
Member

araffin commented Apr 29, 2024

@araffin araffin changed the title Decrease swimmer gamma Decrease gamma for SAC on Swimmer-v4 Apr 29, 2024
@araffin
Copy link
Member

araffin commented Apr 29, 2024

So, the results look good.
I'm doing some run with CrossQ (cc @danielpalen) and it seems that it also now solves the env consistently with gamma=0.999, although it is not more sample efficient as SAC.

cc @osigaud for the results with SAC/TQC/CrossQ (maybe we should update the paper after)

EDIT: I added the result for TQC, I guess we need to update its hyperparameters too

@araffin araffin self-requested a review May 2, 2024 11:49
@araffin araffin changed the title Decrease gamma for SAC on Swimmer-v4 Decrease gamma for SAC/TQC on Swimmer-v4 May 3, 2024
Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

@araffin araffin merged commit 27e081e into DLR-RM:master May 3, 2024
8 checks passed
@JacobHA JacobHA deleted the patch-1 branch May 5, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants