Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --gym-packages parameter to push_to_hub #315

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

ernestum
Copy link
Collaborator

@ernestum ernestum commented Nov 16, 2022

Description

Adds a --gym-packages parameter to the rl_zoo3.push_to_hub command just like with the rl_zoo3.train command.

Motivation and Context

For the rl_zoo3.train command line there is the --gym-packages parameter to allow for importing foreign gym packages.
When you want to upload the trained model to HuggingFace this will fail since the rl_zoo3.push_to_hub command has no such parameter and therefore the upload script won't be able to create an environment to render a preview for HuggingFace.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

ernestum and others added 19 commits April 18, 2022 12:12
* Replace diverted MedianPruner by NopPruner

* Update changelog

Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>
* Dox fixes and move to python 3.7+ style

* Fix type

* Fix broken packages
Add seals environments and corresponding (tentative) hyperparameters.
# Conflicts:
#	requirements.txt
#	rl_zoo3/import_envs.py
Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the commited changes do not correspond to the described feature, no?

EDIT: otherwise, this is indeed a needed feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants