Rebase pr 53 / simplify nix wrapping #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srhb
changed the title
Remove a bunch of stuff from the "dev" shell and rely on normal nix builds/shell instead. This does drop some features like automatically updating the vendorSha256, but hopefully the simpler setup means running `go get -u`, `nix-build` and manually ensuring hash consistency feels intuitive
srhb
changed the title
johanot
approved these changes
May 4, 2021
kalbasit
reviewed
May 4, 2021
| main.version=${version} | ||
| ''; | ||
|
|
||
| vendorSha256 = "08zzp0h4c4i5hk4whz06a3da7qjms6lr36596vxz0d8q0n7rspr9"; |
There was a problem hiding this comment.
If you store the dependencies in your Git repository then this can become set to null. See https://nixos.org/manual/nixpkgs/stable/#ssec-go-modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything but the last commit is rebasing/fixups of #53 .
The rest is simplification of the nix-shell and build, which is opinionated and drops features from the shell. We can re-add things as needed, but for now I didn't manage to get most of it working correctly with go modules, and prefer to rely on "normal Nix idioms".
Feel free to have strong opinions. :)