Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2410: Round out the Fund model with UI #2824

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cameron-hicks
Copy link

@cameron-hicks cameron-hicks commented Jan 26, 2023

This pull request makes the following changes:

  • adds FundsController
  • adds show and edit views for Fund

TODO:

  • passing specs

It relates to the following issue #s:

For reviewer:

  • Adjust the title to explain what it does for the notification email to the listserv.
  • Tag this PR:
    • feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
    • dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.
  • If it contains neither, no need to tag this PR.

@cameron-hicks cameron-hicks changed the title Show and update actions for Fund #2410: Show and update actions for Fund Jan 26, 2023
@colinxfleming
Copy link
Member

looking pretty sharp so far from a skim! @cameron-hicks let me know if/when you'd like either me or Kat to take a deeper look but otherwise we'll wait until this is marked ready for review. Nice to have you back!

@cameron-hicks cameron-hicks changed the title #2410: Show and update actions for Fund #2410: Round out the Fund model with UI Mar 16, 2023
@cameron-hicks cameron-hicks marked this pull request as ready for review August 9, 2023 23:49
@cameron-hicks
Copy link
Author

finally got an evening to return to this one! sorry it's so old! I think I've got all the specs passing but we shall see what CI does... @colinxfleming @lomky

@cameron-hicks
Copy link
Author

I see a couple linters failed, I'll fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round out the Fund model with UI
2 participants