Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round out the Fund model with UI #2410

Open
lomky opened this issue Oct 21, 2021 · 2 comments · May be fixed by #2824
Open

Round out the Fund model with UI #2410

lomky opened this issue Oct 21, 2021 · 2 comments · May be fixed by #2824
Assignees
Labels
Milestone

Comments

@lomky
Copy link
Member

lomky commented Oct 21, 2021

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

  • What are we trying to do?
  • Create a Fund data edit page, restricted to admin editing
@lomky lomky added the frontend label Oct 21, 2021
@colinxfleming colinxfleming changed the title Round out the Fund model Round out the Fund model with UI Jan 21, 2023
@colinxfleming
Copy link
Member

yep, let's do this! Some fields on this model are sacred but some are safe to change. I think roughly:

  • in its own controller/view, permissioned to admin only (Configs is a safe approach to copy)
  • accessible thru the admin dropdown in the toolbar

image

* let's have the URLs be GET /funds/edit for the form view, and PUT/PATCH /funds for the update action (similar to how `users` actions are set up). This is because a user session should be scoped to a particular fund as is and there's never a reason to have multiple-fund access like that. * fields that should be editable: full_name, site_domain, phone

@colinxfleming colinxfleming added this to the Hacknights! milestone Jan 21, 2023
@cameron-hicks
Copy link

Starting on this! Pairing welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants