Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/examples updated README and requirements #984

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Jun 25, 2024

Address a user's bug submission

I’ve been working through the hamilton_ui example (https://github.com/DAGWorks-Inc/hamilton/tree/main/examples/hamilton_ui), and a a minor error popped up (I wouldn’t even call it that). When running the example, the python run.py bit, it gave a ValueError: The 'dtype_backend' argument is not supported for the fastparquet engine error. I fixed this by installing pyarrow, which is not currently listed in the requirements.txt file.
Second, the REAMDE.MD file is a bit outdated.
Current:
python run.py --email --project_id <project_id>
should be
python run.py --username --project_id <project_id>
and
python run.py --email --project_id <project_id> --load-from-parquet True
should be
python run.py --username --project_id <project_id> --load-from-parquet
without the True flag.

@zilto zilto added bug Something isn't working examples Related to code under `examples/` labels Jun 25, 2024
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zilto zilto merged commit 55941c0 into main Jun 25, 2024
23 checks passed
@zilto zilto deleted the fix/examples-hamilton-ui branch June 25, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working examples Related to code under `examples/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants