Fix for node grouping bug (See #948) #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
hanging-parallelism
branch
from
44cbb73
to
b3468ab
Compare
elijahbenizzy
force-pushed
the
hanging-parallelism
branch
from
b3468ab
to
36c916c
Compare
skrawcz
reviewed
Jun 12, 2024
elijahbenizzy
force-pushed
the
hanging-parallelism
branch
2 times, most recently
from
782a96f
to
6eda909
Compare
skrawcz
approved these changes
Jun 12, 2024
Before we had difficulty with the traversal when determining a parallel block. The algorithm was broken and would often traverse to the end, including source nodes. This just rewrites it -- I didn't bother debugigng because the approach was not great from the start. This does a simple DFS + uses a nonlocal variable to track the origin (and update it), so we can return it. See #948 for context.
elijahbenizzy
force-pushed
the
hanging-parallelism
branch
from
6eda909
to
5810f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.