Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print statements when reading/writing cache values. #1049

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

kemaleren
Copy link
Contributor

@kemaleren kemaleren commented Jul 20, 2024

Remove print statements in write_pickle_object and read_pickle_object.

When running a large pipeline with multiple cached values, it's a lot of unnecessary noise on screen. Also, when using the ProgressBar adapter, the print statements interfere with the progress bar.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Remove print statements in `write_pickle_object` and `read_pickle_object`.

When running a large pipeline with multiple cached values, it's a lot of unnecessary noise on screen. Also, when using the `ProgressBar` adapter, the print statements interfere with the progress bar.
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Thanks for catching @kemaleren ! :shipit:

@skrawcz skrawcz merged commit 9048bca into DAGWorks-Inc:main Jul 20, 2024
24 checks passed
@skrawcz
Copy link
Collaborator

skrawcz commented Jul 20, 2024

Will push this out Monday or Tuesday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants