Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces pyspark dependencies #1018

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

elijahbenizzy
Copy link
Collaborator

Removes some dependencies + inline imports, adds tests

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Goal is to keep our dependencies small -- this also is unneeded unless
pyspark connect is already installed, so we can safely inline import it.
@elijahbenizzy elijahbenizzy force-pushed the spark-connect-reduce-dependencies branch from 06a339e to 0fcefdd Compare July 5, 2024 18:56
@elijahbenizzy elijahbenizzy force-pushed the spark-connect-reduce-dependencies branch from 0fcefdd to 6030ba7 Compare July 5, 2024 20:48
@elijahbenizzy elijahbenizzy merged commit 87c5de0 into main Jul 5, 2024
23 checks passed
@elijahbenizzy elijahbenizzy deleted the spark-connect-reduce-dependencies branch July 5, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant