-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
bors try |
bors try |
tryAlready running a review |
bors try- |
bors try |
bors try - |
tryAlready running a review |
bors try |
tryAlready running a review |
bors try- |
tryBuild succeeded: |
@martindevans I rebased this branch onto master, that's why all those files are listed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some formatting choices are certainly contentious, like using Rust 2015.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops
I have approved this, but I'm assuming this is a very minimal/non-intrusive set of formatting checks. I still think we don't need/want an auto formatter at all. |
502c062
to
abd8325
Compare
@Nyefari can you resolve the clippy lint failure? Push to this branch |
@martindevans there are additional clippy lints that appear if you run locally, please resolve them and push to this branch as well |
Similar issue as Martin. Rust analyzer says it can't find bounded_planet::networking but cargo check and cargo clippy both work fine. Issue resolved by cargo clean, restarting vs code, then cargo check |
bors r+ |
Build succeeded: |
Closes #21
Todo:
Cargo.lock
hashing