Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

21 advanced GitHub actions #22

Merged
merged 9 commits into from
Sep 27, 2020
Merged

21 advanced GitHub actions #22

merged 9 commits into from
Sep 27, 2020

Conversation

Jerald
Copy link
Member

@Jerald Jerald commented Sep 24, 2020

Closes #21

Todo:

  • Trial changing caching back to Cargo.lock hashing
  • Rebase and squash changes so history isn't horrific
  • Ensure bors is happy with actions setup

@Jerald Jerald self-assigned this Sep 24, 2020
@Jerald Jerald marked this pull request as ready for review September 24, 2020 20:15
@Jerald
Copy link
Member Author

Jerald commented Sep 25, 2020

bors try

bors bot added a commit that referenced this pull request Sep 25, 2020
@Jerald
Copy link
Member Author

Jerald commented Sep 25, 2020

bors try

@bors
Copy link
Contributor

bors bot commented Sep 25, 2020

try

Already running a review

@Jerald
Copy link
Member Author

Jerald commented Sep 25, 2020

bors try-

@Jerald
Copy link
Member Author

Jerald commented Sep 25, 2020

bors try

bors bot added a commit that referenced this pull request Sep 25, 2020
@Jerald
Copy link
Member Author

Jerald commented Sep 25, 2020

bors try -

@bors
Copy link
Contributor

bors bot commented Sep 25, 2020

try

Already running a review

@Jerald
Copy link
Member Author

Jerald commented Sep 25, 2020

bors try

@bors
Copy link
Contributor

bors bot commented Sep 25, 2020

try

Already running a review

@Jerald
Copy link
Member Author

Jerald commented Sep 25, 2020

bors try-
bors try

bors bot added a commit that referenced this pull request Sep 25, 2020
@bors
Copy link
Contributor

bors bot commented Sep 25, 2020

try

Build succeeded:

docs/Creative Promises.md Outdated Show resolved Hide resolved
docs/Cultural Values.md Outdated Show resolved Hide resolved
docs/Design Values.md Outdated Show resolved Hide resolved
docs/Features (all).md Outdated Show resolved Hide resolved
docs/Foggy Notions.md Outdated Show resolved Hide resolved
docs/Interaction Paradigms.md Outdated Show resolved Hide resolved
docs/Settings.md Outdated Show resolved Hide resolved
src/land/land.rs Outdated Show resolved Hide resolved
src/land/land.rs Outdated Show resolved Hide resolved
src/land/land.rs Outdated Show resolved Hide resolved
@Jerald
Copy link
Member Author

Jerald commented Sep 25, 2020

@martindevans I rebased this branch onto master, that's why all those files are listed

Copy link
Contributor

@ocornoc ocornoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting choices are certainly contentious, like using Rust 2015.

rustfmt.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@ocornoc ocornoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

rustfmt.toml Outdated Show resolved Hide resolved
rustfmt.toml Outdated Show resolved Hide resolved
@martindevans
Copy link
Contributor

I have approved this, but I'm assuming this is a very minimal/non-intrusive set of formatting checks. I still think we don't need/want an auto formatter at all.

@Jerald
Copy link
Member Author

Jerald commented Sep 26, 2020

@Nyefari can you resolve the clippy lint failure? Push to this branch

@Jerald
Copy link
Member Author

Jerald commented Sep 26, 2020

@martindevans there are additional clippy lints that appear if you run locally, please resolve them and push to this branch as well

@martindevans
Copy link
Contributor

Rust Analyser is confused when in this branch. I have these false positives:

Code_2020-09-26_17-22-51

But the build for both client and server binaries succeeds and cargo check show nothing.

@Nyefari
Copy link
Contributor

Nyefari commented Sep 26, 2020

Similar issue as Martin. Rust analyzer says it can't find bounded_planet::networking but cargo check and cargo clippy both work fine.

Issue resolved by cargo clean, restarting vs code, then cargo check

@Jerald
Copy link
Member Author

Jerald commented Sep 27, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 27, 2020

Build succeeded:

@bors bors bot merged commit 37662fa into master Sep 27, 2020
@bors bors bot deleted the 21-advanced-github-actions branch September 27, 2020 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More advanced github actions
4 participants