fixed JSON schema id #84
Conversation
|
hm, CI is breaking. |
|
The build was relying on an old SNAPSHOT of CycloneDX Core Java which was used at the time of the release of the v1.3 spec. The build needed to be updated to a released version of Core Java, which I have just done. Future builds should pass. |
jkowalleck
force-pushed
the
bugfix/83_duplicate_ids_in_JSON
branch
from
d1851e8
to
cdf2d29
Compare
|
thanks, @stevespringett . |
|
@stevespringett could you revisit this PR? |
|
@jkowalleck We're currently working on the v1.4-dev branch and already have 1 PR submitted. I'll likely have another one this weekend. But I'd like to include all of these fixes in the v1.4-dev branch when everything is merged into that branch prior to merging to master. |
|
@stevespringett feel free to change this PR's target branch to whatever branch you prefer. :) |
|
done with a review. feel free to change the merge target from |
jkowalleck
force-pushed
the
bugfix/83_duplicate_ids_in_JSON
branch
from
cdf2d29
to
269fbe2
Compare
| @@ -834,7 +820,6 @@ | |||
| ] | |||
| }, | |||
| "hashes": { | |||
| "$id": "#/properties/hashes", | |||
| @@ -809,7 +795,6 @@ | |||
| ] | |||
| }, | |||
| "hashes": { | |||
| "$id": "#/properties/hashes", | |||
part of CycloneDX#83 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
part of CycloneDX#83 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
bugfix/83_duplicate_ids_in_JSON
branch
from
269fbe2
to
d22e948
Compare
|
Fixed in 1.4. Core Working Group has not made a decision on whether to backport. |
|
related to #123 |
| @@ -27,14 +26,12 @@ | |||
| ] | |||
| }, | |||
| "specVersion": { | |||
| "$id": "#/properties/specVersion", | |||
There was a problem hiding this comment.
$id is the same value the JSON pointer has. so the $id is shadowing the exact same element and can therefore be removed.
|
Closing in favor of #125 |
- CycloneDX/specification#123 - CycloneDX/specification#84 - CycloneDX/specification#125 Signed-off-by: Paul Horton <phorton@sonatype.com>
is part to #83
$iddefinitions$idmarkers that were just json-pointers prefixed with#(self-shadowing)