Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: LicenseExpression() optional args are named args #595

Merged

Conversation

jkowalleck
Copy link
Member

fixes #594

@jkowalleck jkowalleck requested a review from a team as a code owner April 19, 2024 14:43
Copy link

codacy-production bot commented Apr 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b40f739) 4504 4185 92.92%
Head commit (68ed0ad) 4504 (+0) 4185 (+0) 92.92% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#595) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck
Copy link
Member Author

jkowalleck commented May 2, 2024

I'll leave this PR here, so it can be picked whenever the next major version is bundled.

@jkowalleck jkowalleck force-pushed the refactor/LicenseExpression-optionals-are-kwargs branch from 66eeac9 to 82f79fe Compare July 4, 2024 10:07
@jkowalleck jkowalleck added this to the 8.0.0 milestone Jul 4, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the refactor/LicenseExpression-optionals-are-kwargs branch from 82f79fe to 68ed0ad Compare July 8, 2024 13:36
@jkowalleck jkowalleck changed the base branch from main to 8.0.0-dev July 19, 2024 16:45
@jkowalleck jkowalleck merged commit 0172564 into 8.0.0-dev Sep 16, 2024
45 checks passed
@jkowalleck jkowalleck mentioned this pull request Sep 16, 2024
@jkowalleck jkowalleck deleted the refactor/LicenseExpression-optionals-are-kwargs branch September 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LicenseExpression's optional arguments should be named arguments
1 participant