Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SPDX v2.3 #353

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

CarolinaOliiveira
Copy link

No description provided.

…92734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…34+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
… <61292734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…ers.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…er.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…inaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
Add Built Date, Release Date and Valid Until Date fields
Make Packages and files properties opctional
Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
… Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…ra <61292734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…Oliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…Oliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…rolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…inaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…aOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…y: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
@p-brito
Copy link

p-brito commented Sep 10, 2024

@coderpatros @stevespringett can you review this?

src/CycloneDX.Spdx/Models/v2_3/SpdxDocument.cs Outdated Show resolved Hide resolved
src/CycloneDX.Spdx/Models/v2_3/SpdxDocument.cs Outdated Show resolved Hide resolved
src/CycloneDX.Spdx/Models/v2_3/Annotation.cs Outdated Show resolved Hide resolved
src/CycloneDX.Spdx/CycloneDX.Spdx.csproj Outdated Show resolved Hide resolved
…-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…2734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…292734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
…734+CarolinaOliiveira@users.noreply.github.com>

Signed-off-by: Carolina Oliveira <61292734+CarolinaOliiveira@users.noreply.github.com>
@mtsfoni
Copy link
Contributor

mtsfoni commented Sep 14, 2024

First of all thank you for the contribution.

I currently maintain this project, however I know only very little about SPDX.

Can you(eg. @Kiril1512) assure me, that you reviewed the code good and deep enough and @CarolinaOliiveira, that you can take time to fix bugs that might arrise from the integration of your code?

@andreas-hilti
Copy link
Contributor

@mtsfoni What is the strategy here with respect to version support? Support only the latest 2.x version of SPDX (or is the aim to support both 2.2 and 2.3)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants