Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for consistency between JSON, xml, and protobuf serialization #331

Draft
wants to merge 20 commits into
base: cdx1.6
Choose a base branch
from

Conversation

andreas-hilti
Copy link
Contributor

No description provided.

…aft)

Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
@andreas-hilti andreas-hilti marked this pull request as draft August 26, 2024 21:25
@andreas-hilti
Copy link
Contributor Author

@mtsfoni This is just a very early and uncleaned version of what I had in mind in terms consistency tests for the different serializations. Some checks are passing; most are failing, due to various reasons (haven't yet studied the results). Some might be actual errors, for some the input might just differ, ...

Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
…aft)

Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
@andreas-hilti
Copy link
Contributor Author

andreas-hilti commented Aug 30, 2024

With all the current changes, there are 4 issues for the json protobuf tests:

  • valid-attestation (signature, timestamps)
  • valid-license-expression (hashes, bom-ref for license expression not supported)
  • valid-metadata-lifecycle (issue serializing lifecycle)
  • valid-metadata-tool (issue with serialization of components and services for tools)

Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
@andreas-hilti andreas-hilti changed the title Add tests for consistency between JSON and protobuf serialization Add tests for consistency between JSON, xml, and protobuf serialization Aug 31, 2024
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
@andreas-hilti
Copy link
Contributor Author

andreas-hilti commented Aug 31, 2024

With all the current changes there is only 1 issue for the xml json tests:

  • valid-bom (different content)

…nd json

Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant