Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sensor_download): add file operation support to module #485

Merged

Conversation

carlosmmatos
Copy link
Contributor

Fixes #481

This PR introduces the built-in files AnsibleModule helper features to manage file operations such as mode, owner, group, etc.

Fixes CrowdStrike#481

This PR introduces the built-in files AnsibleModule helper features to manage
file operations such as mode, owner, group, etc.
@carlosmmatos carlosmmatos added bugfixes Bug fixes or minor enhancements enhancement New feature or request labels Apr 6, 2024
@carlosmmatos carlosmmatos self-assigned this Apr 6, 2024
@carlosmmatos carlosmmatos added this to the 4.4.1 milestone Apr 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 37.51%. Comparing base (a7c58af) to head (1a1eb9c).
Report is 4 commits behind head on main.

Files Patch % Lines
plugins/modules/sensor_download.py 12.50% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   37.75%   37.51%   -0.24%     
==========================================
  Files          17       17              
  Lines         837      845       +8     
  Branches      161      162       +1     
==========================================
+ Hits          316      317       +1     
- Misses        520      527       +7     
  Partials        1        1              
Flag Coverage Δ
sanity 37.51% <12.50%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@redhatrises redhatrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the file mode example, 755 looks weird for a non-executable file.

@redhatrises redhatrises merged commit b3d44b6 into CrowdStrike:main Apr 6, 2024
6 checks passed
@dhoppe
Copy link

dhoppe commented Apr 9, 2024

@carlosmmatos I am glad that the module sensor_download is now able to change the owner, group and mode, but the role does not yet have the corresponding variables / defaults.

@carlosmmatos
Copy link
Contributor Author

Dope 🤦🏻‍♂️. You're right, I was caught up in the process of updating the sensor module that I forgot that needs to be applied to the role. Apologies for that, I will have that out by end of day.

@carlosmmatos
Copy link
Contributor Author

@dhoppe check out the latest PR #497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfixes Bug fixes or minor enhancements enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[falcon_install] Add ability to change permissions of the downloaded Falcon Sensor Installer
4 participants