Skip to content

Commit

Permalink
chore(falconctl): remove provisioning_token, not needed
Browse files Browse the repository at this point in the history
After testing some more, realized that the reason we didn't get this
option is because it doesn't make sense due to the way it behaves.
  • Loading branch information
carlosmmatos committed Aug 8, 2024
1 parent ce00984 commit 12b90d5
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 9 deletions.
1 change: 1 addition & 0 deletions molecule/falcon_configure_remove_aid/molecule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@ scenario:
- create
- prepare
- converge
- idempotence
- verify
- destroy
6 changes: 0 additions & 6 deletions molecule/falcon_configure_remove_aid/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
ansible.builtin.assert:
that:
- info_verify.falconctl_info.cid
- info_verify.falconctl_info.provisioning_token
- info_verify.falconctl_info.tags

- name: Verify AID is not present
Expand Down Expand Up @@ -43,11 +42,6 @@
that:
- new_info_verify.falconctl_info.aid

- name: Validate Provisioning Token is not present
ansible.builtin.assert:
that:
- not new_info_verify.falconctl_info.provisioning_token

- name: Validate CID and Tags are still present
ansible.builtin.assert:
that:
Expand Down
1 change: 0 additions & 1 deletion plugins/module_utils/falconctl_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"message_log",
"billing",
"tags",
'provisioning_token',
"version",
"rfm_state",
"rfm_reason",
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/falconctl.py
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def main(): # pylint: disable=missing-function-docstring
module_args = dict(
state=dict(required=True, choices=["absent", "present"], type="str"),
cid=dict(required=False, type="str"),
provisioning_token=dict(required=False, no_log=True, type="str"),
provisioning_token=dict(required=False, type="str"),
aid=dict(required=False, type="bool"),
apd=dict(required=False, type="str"),
aph=dict(required=False, type="str"),
Expand Down
1 change: 0 additions & 1 deletion plugins/modules/falconctl_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
'message_log',
'billing',
'tags',
'provisioning_token',
'version',
'rfm_state',
'rfm_reason',
Expand Down

0 comments on commit 12b90d5

Please sign in to comment.