Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAYSAT-1884: Updating cray-product-catalog & csm-api-client to latest versions #258

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

shivaprasad-metimath
Copy link
Contributor

@shivaprasad-metimath shivaprasad-metimath commented Aug 21, 2024

Summary and Scope

Updating cray-product-catalog & csm-api-client to latest versions

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Testing

List the environments in which these changes were tested.

Tested on:

  • Rocket,Gamora,Surtur

Test description:

Test the below SAT utilities
sat showrev --products
sat bootprep
cfs-config-util

Risks and Mitigations

Minimal

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@shivaprasad-metimath
Copy link
Contributor Author

Testing was done on surtur,rocket for lower versions than 2.3.1 and for 2.3.1 it was tested on gamora system.
Sat showrev,bootprep were tested along with cfs-config-util.
Below is the link to complete output: https://gist.github.com/shivaprasad-metimath/432dbacecaa4346b011777dc5863ec80

Copy link
Contributor

@annapoorna-s-alt annapoorna-s-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially you are on track. The code changes looks good to me. But, you have to update new version of cray-product-catalog in cfs-config-util repository, get the new unstable build and test with cfs-config-util commands.
Testing cfs-config-util commands with this build doesn't make sense to me.

@shivaprasad-metimath
Copy link
Contributor Author

Partially you are on track. The code changes looks good to me. But, you have to update new version of cray-product-catalog in cfs-config-util repository, get the new unstable build and test with cfs-config-util commands. Testing cfs-config-util commands with this build doesn't make sense to me.

Ok, the testing for cfs-config-util will be done with new unstable build in respective repo. are this repo specific testing satisfactory?
Let me know if any comments, else will proceed with merging this PR and raise a separate one for cfs-config-util repo

@annapoorna-s-alt
Copy link
Contributor

Partially you are on track. The code changes looks good to me. But, you have to update new version of cray-product-catalog in cfs-config-util repository, get the new unstable build and test with cfs-config-util commands. Testing cfs-config-util commands with this build doesn't make sense to me.

Ok, the testing for cfs-config-util will be done with new unstable build in respective repo. are this repo specific testing satisfactory? Let me know if any comments, else will proceed with merging this PR and raise a separate one for cfs-config-util repo

Yes, the other testings are pretty good. But once the PR on cfs-config-util merges, I would request you to do sanity tests on this repo as the version updates are critical. Then you feel free to merge

Copy link
Contributor

@annapoorna-s-alt annapoorna-s-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the code changes as testing of related sat commands looks good

@shivaprasad-metimath shivaprasad-metimath merged commit c40ad0e into main Aug 29, 2024
3 checks passed
@shivaprasad-metimath shivaprasad-metimath deleted the CRAYSAT-1884-new-version-update-CPC branch August 29, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants