Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAYSAT-1581: Updating acceptable checks in ceph health validation stage #238

Conversation

shivaprasad-metimath
Copy link
Contributor

@shivaprasad-metimath shivaprasad-metimath commented Jul 11, 2024

IM:CRAYSAT-1581
Reviewer:Ryan

Summary and Scope

During the ceph health validation,in ncn-power stage.PG_NOT_DEEP_SCRUBBED check would be in health_warn status and that would abort the next steps following ceph health check as pgs not deep-scrubbed in time. Since it can be ignored, we are adding it to the acceptable checkswhich can be not considered while returning the ceph health.

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Testing

List the environments in which these changes were tested.

Tested on:

  • Yet to be tested

Test description:

Will have power on and power off the ncn's. To validate the changes and see how it behaves during the ceph health check.

Risks and Mitigations

minimal

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@shivaprasad-metimath shivaprasad-metimath force-pushed the CRAYSAT-1851-bootsys-ps-ceph-health-tolerance branch 2 times, most recently from b4eb97f to b0e7a3c Compare July 11, 2024 11:44
@shivaprasad-metimath shivaprasad-metimath changed the title Updating acceptable checks in ceph helath validation stage CRAYSAT-1581: Updating acceptable checks in ceph helath validation stage Jul 11, 2024
Copy link
Contributor

@haasken-hpe haasken-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

Copy link
Contributor

@annapoorna-s-alt annapoorna-s-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comment
As it may not reproducible issue, I feel it is good to add PG_NOT_DEEP_SCRUBBED flag in test_ceph_warn_healthy unit test case also where we've Ceph is healthy with warnings...

Address the typo of ceph health in title

@shivaprasad-metimath shivaprasad-metimath changed the title CRAYSAT-1581: Updating acceptable checks in ceph helath validation stage CRAYSAT-1581: Updating acceptable checks in ceph health validation stage Jul 12, 2024
@shivaprasad-metimath shivaprasad-metimath force-pushed the CRAYSAT-1851-bootsys-ps-ceph-health-tolerance branch 2 times, most recently from f45c013 to 9a87ee2 Compare July 12, 2024 06:09
IM:CRAYSAT-1581
Reviewer:Ryan

During the ceph health validation,in ncn-power stage.PG_NOT_DEEP_SCRUBBED
check would be in health_warn status and that would abort the next steps following
ceph health check as pgs not deep-scrubbed in time. Since it can be ignored, we are
adding it to the acceptable checkswhich can be not considered while returning the ceph health.
@shivaprasad-metimath shivaprasad-metimath force-pushed the CRAYSAT-1851-bootsys-ps-ceph-health-tolerance branch 2 times, most recently from d9a1939 to 1c6cb2b Compare July 12, 2024 06:41
@shivaprasad-metimath shivaprasad-metimath merged commit 229f3d1 into feature/CRAYSAT-1740 Jul 15, 2024
3 checks passed
@shivaprasad-metimath shivaprasad-metimath deleted the CRAYSAT-1851-bootsys-ps-ceph-health-tolerance branch July 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants