Charge gas to unzip wasm code #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 59.34% 59.31% -0.03%
==========================================
Files 51 51
Lines 6221 6229 +8
==========================================
+ Hits 3692 3695 +3
- Misses 2264 2268 +4
- Partials 265 266 +1
|
webmaster128
reviewed
Aug 4, 2022
|
The reasoning behind this one is super-solid. |
|
I have applied the feedback and rebased the branch on top of main. |
pinosu
reviewed
Aug 25, 2022
pinosu
reviewed
Aug 25, 2022
pinosu
reviewed
Aug 25, 2022
pinosu
reviewed
Aug 25, 2022
Closed
conorpp
pushed a commit
to wormhole-foundation/wasmd
that referenced
this pull request
Feb 1, 2023
* Charge gas for unzip wasm code * Add uncompress test * Apply review feedback * Add testcase to uncompress spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncompressing packed wasm code should be paid in gas to compensate for CPU.
Early version for feedback. Left to do:- Set proper cost per byte value
Not included is an ante handler to verify gas. But we don't do this for costs per bytes either.