Copy wrapped resource's attributes into the service #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
reviewed
Aug 31, 2020
Update the generated service to look like the resource it is wrapping.
|
Added a test case, let me know if that works for you. |
leplatrem
approved these changes
Sep 1, 2020
| (x.name, x) for x in self.config.registry.cornice_services.values() | ||
| if x.name in resources | ||
| ): | ||
| for attr in functools.WRAPPER_ASSIGNMENTS: |
There was a problem hiding this comment.
TIL WRAPPER_ASSIGNMENTS :) 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Service is generated from a Resource, it losses all the attributes from the resource (specifically the docstring). This change ensures that the wrapping service looks like it wrapped resource.
This is particularly useful since when I list the services registered by Cornice (
config.registry.cornice_services), I need to have access to the original docstring.Since the service is based on the resource, it makes also sense to mimic its attributes.