-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Resource predicates support #344
Conversation
Thanks for your contribution! The feature does not look irrelevant to me. I witl let @almet confirm, but it is sure that it can't land in master without tests :) |
I confirm, this would be useful, but needs testing. |
@vmaksymiv would you have some time to contribute a couple of tests ? |
…rce_custom_predicates Tests for resource custom predicates
…rce_custom_predicates Tests for custom predicates
1 similar comment
…rce_custom_predicates pep fixes
Hello! |
Great! Thanks for your additional efforts on this! Indeed, I agree with your comment. This particular line is impossible to reach, and didn't feel confident enough to get rid of it during the 2.0 refactor (See https://github.com/Cornices/cornice/blob/master/tests/test_pyramidhook.py#L280-L289). |
It allows to register different Resources with the same path.
Ex.