Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eip4844 types #6421

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Eip4844 types #6421

merged 4 commits into from
Nov 10, 2022

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Nov 10, 2022

PR Description

  • I put minimal logic in KZGCommitment to KZGProof as its imlementation is another task, it looks like compressed point from the spec so I left similar to BLS method
  • I'm not sure what's the correct place for Blob datastructure, I put it in blocks.blob
  • for Blob I cannot do roundtrip test until Milestone defined, which requires SpecLogic

Fixed Issue(s)

Fixes #6378

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@zilm13 zilm13 changed the title Eip4844 tyoes Eip4844 types Nov 10, 2022
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

WRT the logic on top of the kzg objects, we don't need to have them in our code. I asked in discord and all the validations mentioned in polynomial commitments will be responsibility of the kzg library.

WRT Blobs placement, I'd be tempted put Blobs and BlobsSidecar under execution\versions\eip4844. At the end we retrieve them via engine API. WDYT?

WRT round trip, can you log it on an issue so we can track it?

@zilm13
Copy link
Contributor Author

zilm13 commented Nov 10, 2022

Added #6422

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zilm13 zilm13 merged commit 095b30d into Consensys:master Nov 10, 2022
@zilm13 zilm13 deleted the eip4844-tyoes branch November 10, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define new types
2 participants