Fix container build: build svm-rs in upstream rust layer #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The container build is green again after the recent PR merges. Maybe this PR is not required. |
|
This happens due to issues with emulating some arm builds on x86 or emulating some x86 builds on arm (It is a bit tedious to perform multiplatform builds on multiple platforms and combine them). So, it crashes once in a while. Will work when restarted. |
|
There was definitely something else as I could reproduce the issue multiple times locally even when building without multiarch emulation... maybe this resolved via some changes in the rustup installer... anyways, it resolved thus closing this PR |
|
Isn't it still useful even without the issue? |
norhh
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new svm-rs version was released yesterday, which breaks the container build see:
This PR fixes the svm-rs build by building in upstream rust container, which has a more complete rust tooling setup and does not run into the
error: linking with `cc` failedissue.Also removes some build layers not needed anymore.