Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make val-tagged work #2

Merged
merged 10 commits into from
Mar 20, 2023
Merged

Changes to make val-tagged work #2

merged 10 commits into from
Mar 20, 2023

Conversation

epureanudiana
Copy link

@epureanudiana epureanudiana commented Mar 13, 2023

I made some adjustments to val.py and put them in a new script, val-tagged.py
I needed some adjustments in metrics.py and created a new metrics-tagged.py

The downside is that the 2 classes are almost the same
The upside is that if yolov5 changes, i think it’s easier to just sync

@epureanudiana epureanudiana marked this pull request as ready for review March 14, 2023 10:17
utils/dataloaders.py Outdated Show resolved Hide resolved
utils/dataloaders.py Outdated Show resolved Hide resolved
utils/dataloaders.py Outdated Show resolved Hide resolved
@epureanudiana
Copy link
Author

you left me a comment last week:
I didn’t really check it yet but I was thinking. In metrics-tagged and val-tagged. Cannot we import from the other files everything that it’s in common and in the new files add only what it’s different?

I made this change in metrics-tagged, good idea! In val-tagged it does not make sense because the file is essentially a huge run() method which I am changing here and there.

@sdavrieux sdavrieux merged commit 7cbdeaa into master Mar 20, 2023
@sdavrieux sdavrieux deleted the tagged-validation branch March 20, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants