-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use editorconfig to check for indentation #9653
Conversation
Skipping CI for Draft Pull Request. |
25953b0
to
a4e7dd5
Compare
Research has shown that the editorconfig is respected - setting the The only solution is to explicitly switch the check off as described in https://editorconfig-specification.readthedocs.io/ |
a4e7dd5
to
905f6a0
Compare
Use double asterisks in the path spec - single ones make rules effective only for top-level files. Next, disable check for indentation width for Python files due to editorconfig/editorconfig#412
905f6a0
to
6adf7de
Compare
Code Climate has analyzed commit 6adf7de and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.8% (0.0% change). View more on Code Climate. |
@Mab879 Could we merge this? It would fix a lot of CodeClimate false positives |
Fix editorconfig - make rules effective for all files, not just the top project level.
The main motivation is to stop enforcing 4-space indentation in Python, as it is not valid in some cases.