Add unit tests for warnings and sub elements #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
This PR needs a rebase, would it be possible to use XMLDiff on these tests as well? |
This commit adds some unit tests for these functions from the ssg.build_yaml module: - add_sub_element() - add_warning_elements() - check_warnings()
jan-cerny
force-pushed
the
test_warnings_and_sub
branch
from
9e54d31
to
7987881
Compare
|
I have rebased the PR on the top of latest master.
It's possible because they work with XML, but I don't plan to use it because I find the tests simple enough in the current form. |
|
Code Climate has analyzed commit 7987881 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 46.2% (0.1% change). View more on Code Climate. |
matejak
approved these changes
Oct 21, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some unit tests for these functions from the ssg.build_yaml module: