-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate XCCDF 1.2 directly #9464
Conversation
Skipping CI for Draft Pull Request. |
Hello @jan-cerny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-09-02 11:03:28 UTC |
I have rebased the PR on the top of the latest master branch and I have resolved the Code Climate problems. |
Use ssg-${PRODUCT}-xccdf.xml instead of ssg-${PRODUCT}-xccdf-1.2.xml everywhere, because both files are now actually in XCCDF 1.2 namespace. This change will allow us to remove the CMake target that converts ssg-${PRODUCT}-xccdf.xml to ssg-${PRODUCT}-xccdf-1.2.xml in future.
The ssg-${product}-xccdf.xml is already an XCCDF 1.2 document so we don't need another XCCDF 1.2 document.
I have resolved the conflict and rebased this PR on the top of the latest upstream master branch. |
Code Climate has analyzed commit 27b8324 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 8.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.6% (0.1% change). View more on Code Climate. |
Description:
Generate XCCDF 1.2 directly from the resolved YAML files. Stop using interim XCCDF 1.1 build step. The
build/$product/shorthand.xml
becomes a valid XCCDF 1.2 file.For more details, please read commit messages of every commit.
Rationale: