Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chronyd_or_ntpd_specify_remote_server: update assertion results #12342

Conversation

yuumasato
Copy link
Member

Description:

  • This updates chronyd_or_ntpd_specify_remote_server assertion results to PASS, they were not updated after a fix landed upstream.

Rationale:

This updates chronyd_or_ntpd_specify_remote_server assertion results to
PASS, they were not updated after a fix landed upstream.
@yuumasato yuumasato added the OpenShift OpenShift product related. label Aug 26, 2024
@yuumasato yuumasato added this to the 0.1.75 milestone Aug 26, 2024
@yuumasato yuumasato requested a review from rhmdnd August 26, 2024 15:50
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@yuumasato
Copy link
Member Author

/test e2e-aws-rhcos4-high
/test e2e-aws-rhcos4-moderate
/test 4.17-e2e-aws-rhcos4-moderate
/test 4.13-e2e-aws-rhcos4-moderate

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12342
This image was built from commit: f8003e7

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12342

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12342 make deploy-local

Copy link

codeclimate bot commented Aug 26, 2024

Code Climate has analyzed commit f8003e7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link

openshift-ci bot commented Aug 26, 2024

@yuumasato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-high f8003e7 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Collaborator

rhmdnd commented Aug 26, 2024

Looks like the rhcos4-high failure was due to usbgaurd:

E2E-FAILURE: The expected result for the e2e-high-worker-configure-usbguard-auditbackend rule didn't match. Expected 'PASS', Got 'FAIL'

Unrelated to this change.

Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato yuumasato merged commit 5ab3a9d into ComplianceAsCode:master Aug 28, 2024
100 of 102 checks passed
@yuumasato yuumasato deleted the 4.17-chronyd-r-ntpd-specify-remote-servers branch August 28, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants